Repository navigation
Add Azure Key Vault certificate version option - #1074
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06da229d-3449-4299-9aa3-c24073ffd97a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06da229d-3449-4299-9aa3-c24073ffd97a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06da229d-3449-4299-9aa3-c24073ffd97a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06da229d-3449-4299-9aa3-c24073ffd97a
dtivel
requested review from
kartheekp-ms
and
a balanced review from Copilot
September 15, 2026 17:26
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The version is correctly propagated, retrieval avoids fallback, backing key IDs are validated, and focused tests cover the behavior.
Review tier: Balanced
Findings: None
What changed in this PR
Adds Azure Key Vault certificate-version selection while ensuring signing uses the certificate’s authoritative backing key.
Changes:
- Adds
--azure-key-vault-certificate-version/-kvcvwith validation. - Retrieves and caches the selected certificate and its versioned cryptography client.
- Adds localized resources and focused CLI/service tests.
| File | Description |
|---|---|
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceTests.cs |
Tests version retrieval, key-ID validation, and caching. |
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs |
Updates service construction. |
test/Sign.Cli.Test/AzureKeyVaultCommandTests.cs |
Tests option parsing, validation, and DI propagation. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.zh-Hant.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.zh-Hans.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.tr.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.ru.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.pt-BR.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.pl.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.ko.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.ja.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.it.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.fr.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.es.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.de.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/xlf/Resources.cs.xlf |
Adds key-ID error resource. |
src/Sign.SignatureProviders.KeyVault/Resources.resx |
Defines the key-ID validation message. |
src/Sign.SignatureProviders.KeyVault/Resources.Designer.cs |
Exposes the new resource. |
src/Sign.SignatureProviders.KeyVault/KeyVaultService.cs |
Retrieves versioned certificates and uses their backing keys. |
src/Sign.Cli/xlf/AzureKeyVaultResources.zh-Hant.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.zh-Hans.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.tr.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.ru.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.pt-BR.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.pl.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.ko.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.ja.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.it.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.fr.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.es.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.de.xlf |
Adds localized option resources. |
src/Sign.Cli/xlf/AzureKeyVaultResources.cs.xlf |
Adds localized option resources. |
src/Sign.Cli/AzureKeyVaultResources.resx |
Defines option description and validation message. |
src/Sign.Cli/AzureKeyVaultResources.Designer.cs |
Exposes the new CLI resources. |
src/Sign.Cli/AzureKeyVaultCommand.cs |
Adds, validates, and propagates the version option. |
Files not reviewed (2)
- src/Sign.Cli/AzureKeyVaultResources.Designer.cs: Generated file
- src/Sign.SignatureProviders.KeyVault/Resources.Designer.cs: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kartheekp-ms
previously approved these changes
Sep 18, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kartheekp-ms
approved these changes
Sep 18, 2026
This was referenced Sep 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--azure-key-vault-certificate-version/-kvcvto select a specific Azure Key Vault certificate version.The implementation:
KeyId, since certificate and key versions can differ.Based on #1046 by @Guflly, preserving the original commit authorship.
Resolves #1005
Testing